]> git.ipfire.org Git - thirdparty/open-vm-tools.git/commitdiff
VMCI: remove memset() before free()
authorVMware, Inc <>
Thu, 2 Aug 2012 05:20:57 +0000 (22:20 -0700)
committerDmitry Torokhov <dtor@vmware.com>
Thu, 2 Aug 2012 18:01:10 +0000 (11:01 -0700)
Strip out redundant calls to memset() before free().

Signed-off-by: Dmitry Torokhov <dtor@vmware.com>
open-vm-tools/modules/linux/vmci/common/vmciQPair.c

index 7465e5d920b401b9b0fb737e145817653f9fa9ea..a3d612f9dbec826a08ba97c7fd16fd7d4b45bda4 100644 (file)
@@ -600,9 +600,6 @@ VMCIQPair_Detach(VMCIQPair **qpair) // IN/OUT
    if (!(oldQPair->guestEndpoint || (oldQPair->flags & VMCI_QPFLAG_LOCAL))) {
       VMCI_DestroyEvent(&oldQPair->event);
    }
-   memset(oldQPair, 0, sizeof *oldQPair);
-   oldQPair->handle = VMCI_INVALID_HANDLE;
-   oldQPair->peer = VMCI_INVALID_ID;
    VMCI_FreeKernelMem(oldQPair, sizeof *oldQPair);
    *qpair = NULL;