]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
Fix stderr bug in json.tool test (#346)
authorDaniel Himmelstein <daniel.himmelstein@gmail.com>
Wed, 15 Mar 2017 14:31:06 +0000 (10:31 -0400)
committerBerker Peksag <berker.peksag@gmail.com>
Wed, 15 Mar 2017 14:31:06 +0000 (17:31 +0300)
See https://github.com/python/cpython/pull/201#discussion_r103229425.

Lib/test/test_json/test_tool.py

index 15f373664e1278a599c9e56bd872ac919d0df556..9d93f931ca395887971265ea26e5ce14ffc5493a 100644 (file)
@@ -2,7 +2,7 @@ import os
 import sys
 import textwrap
 import unittest
-import subprocess
+from subprocess import Popen, PIPE
 from test import support
 from test.support.script_helper import assert_python_ok
 
@@ -61,12 +61,11 @@ class TestTool(unittest.TestCase):
     """)
 
     def test_stdin_stdout(self):
-        with subprocess.Popen(
-                (sys.executable, '-m', 'json.tool'),
-                stdin=subprocess.PIPE, stdout=subprocess.PIPE) as proc:
+        args = sys.executable, '-m', 'json.tool'
+        with Popen(args, stdin=PIPE, stdout=PIPE, stderr=PIPE) as proc:
             out, err = proc.communicate(self.data.encode())
         self.assertEqual(out.splitlines(), self.expect.encode().splitlines())
-        self.assertEqual(err, None)
+        self.assertEqual(err, b'')
 
     def _create_infile(self):
         infile = support.TESTFN