]> git.ipfire.org Git - thirdparty/freeradius-server.git/commitdiff
don't do strlen() on secret
authorAlan T. DeKok <aland@freeradius.org>
Sat, 8 Sep 2018 13:43:58 +0000 (09:43 -0400)
committerAlan T. DeKok <aland@freeradius.org>
Sat, 8 Sep 2018 13:43:58 +0000 (09:43 -0400)
src/modules/rlm_radius/rlm_radius_udp.c

index 2a52303b0832945d0495cf390ca33f24a157761d..2b4733b3e887ee25c3c489ec07cfe3c75c293e99 100644 (file)
@@ -843,7 +843,7 @@ check_active:
        memcpy(original + 4, rr->vector, sizeof(rr->vector));
 
        if (fr_radius_verify(c->buffer, original,
-                            (uint8_t const *) c->inst->secret, strlen(c->inst->secret)) < 0) {
+                            (uint8_t const *) c->inst->secret, talloc_array_length(c->inst->secret) - 1) < 0) {
                RPWDEBUG("Ignoring response with invalid signature");
                goto redo;
        }