Fix IKEv1 DPD clear, destroying IKE_SA even if reestablish not needed

diff --git a/src/libcharon/processing/jobs/dpd_timeout_job.c b/src/libcharon/processing/jobs/dpd_timeout_job.c
index c3337996b86fbffc2e6d331354bcf09105f2c903..4f427f1d3d4babaebf974d1933056b1d87d3ac62 100644 (file)
--- a/src/libcharon/processing/jobs/dpd_timeout_job.c
+++ b/src/libcharon/processing/jobs/dpd_timeout_job.c
@@ -77,15 +77,9 @@ METHOD(job_t, execute, void,
                if (use_time < this->check)
                {
                        DBG1(DBG_JOB, "DPD check timed out, enforcing DPD action");
-                       if (ike_sa->reestablish(ike_sa) == SUCCESS)
-                       {
-                               charon->ike_sa_manager->checkin_and_destroy(
-                                                                                       charon->ike_sa_manager, ike_sa);
-                       }
-                       else
-                       {
-                               charon->ike_sa_manager->checkin(charon->ike_sa_manager, ike_sa);
-                       }
+                       ike_sa->reestablish(ike_sa);
+                       charon->ike_sa_manager->checkin_and_destroy(charon->ike_sa_manager,
+                                                                                                               ike_sa);
                }
                else
                {