app-layer-ssl: code cleanup

Don't alloc a void ptr and then cast in every operation. Instead,
alloc a SSLState ptr and only case to void on returning the ptr.

diff --git a/src/app-layer-ssl.c b/src/app-layer-ssl.c
index d00709cfa1a5a7e75d5bea42cad9daadbb0dd1bc..53672803cf682944e5e2aad8615ee955264f3810 100644 (file)
--- a/src/app-layer-ssl.c
+++ b/src/app-layer-ssl.c
@@ -951,15 +951,15 @@ int SSLParseServerRecord(Flow *f, void *alstate, AppLayerParserState *pstate,
  */
 void *SSLStateAlloc(void)
 {
-    void *ssl_state = SCMalloc(sizeof(SSLState));
+    SSLState *ssl_state = SCMalloc(sizeof(SSLState));
     if (unlikely(ssl_state == NULL))
         return NULL;
     memset(ssl_state, 0, sizeof(SSLState));
-    ((SSLState*)ssl_state)->client_connp.cert_log_flag = 0;
-    ((SSLState*)ssl_state)->server_connp.cert_log_flag = 0;
-    TAILQ_INIT(&((SSLState*)ssl_state)->server_connp.certs);
+    ssl_state->client_connp.cert_log_flag = 0;
+    ssl_state->server_connp.cert_log_flag = 0;
+    TAILQ_INIT(&ssl_state->server_connp.certs);
 
-    return ssl_state;
+    return (void *)ssl_state;
 }
 
 /**