can: mcp251x: mcp251x_can_probe(): add missing unregister_candev() in error path

[ Upstream commit b1a09b63684cea56774786ca14c13b7041ffee63 ]

In mcp251x_can_probe(), if mcp251x_gpio_setup() fails, it forgets to
unregister the CAN device.

Fix this by unregistering can device in mcp251x_can_probe().

Fixes: 2d52dabbef60 ("can: mcp251x: add GPIO support")
Signed-off-by: Dongliang Mu <dzm91@hust.edu.cn>
Link: https://lore.kernel.org/all/20221024090256.717236-1-dzm91@hust.edu.cn
[mkl: adjust label]
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/drivers/net/can/spi/mcp251x.c b/drivers/net/can/spi/mcp251x.c
index c320de474f406fe26ea25aeba8170fad3663e671..24883a65ca66a3702c43b8661107f53d19fcabb0 100644 (file)
--- a/drivers/net/can/spi/mcp251x.c
+++ b/drivers/net/can/spi/mcp251x.c
@@ -1415,11 +1415,14 @@ static int mcp251x_can_probe(struct spi_device *spi)
 
        ret = mcp251x_gpio_setup(priv);
        if (ret)
-               goto error_probe;
+               goto out_unregister_candev;
 
        netdev_info(net, "MCP%x successfully initialized.\n", priv->model);
        return 0;
 
+out_unregister_candev:
+       unregister_candev(net);
+
 error_probe:
        destroy_workqueue(priv->wq);
        priv->wq = NULL;