]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
phy: qcom: qmp-usbc: Simplify check for non-NULL pointer
authorKrzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Mon, 16 Feb 2026 11:04:16 +0000 (12:04 +0100)
committerVinod Koul <vkoul@kernel.org>
Fri, 27 Feb 2026 14:33:38 +0000 (20:03 +0530)
Pointers should not use explicit '0' comparison, so just use standard
evaluation as non-NULL:

  phy-qcom-qmp-usbc.c:1682:31: warning: Using plain integer as NULL pointer

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Reviewed-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Link: https://patch.msgid.link/20260216110413.159994-6-krzysztof.kozlowski@oss.qualcomm.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/phy/qualcomm/phy-qcom-qmp-usbc.c

index 14feb77789b3e1bd82950471aa5a10b50ed2b8ab..c342479a3798007349e7e3039b7e1a2c6ce9e021 100644 (file)
@@ -1679,7 +1679,7 @@ static int qmp_usbc_register_clocks(struct qmp_usbc *qmp, struct device_node *np
        if (ret)
                return ret;
 
-       if (qmp->dp_serdes != 0) {
+       if (qmp->dp_serdes) {
                ret = phy_dp_clks_register(qmp, np);
                if (ret)
                        return ret;
@@ -1833,7 +1833,7 @@ static int qmp_usbc_parse_dt(struct qmp_usbc *qmp)
        if (IS_ERR(base))
                return PTR_ERR(base);
 
-       if (offs->dp_serdes != 0) {
+       if (offs->dp_serdes) {
                qmp->dp_serdes = base + offs->dp_serdes;
                qmp->dp_tx = base + offs->dp_txa;
                qmp->dp_tx2 = base + offs->dp_txb;
@@ -1982,7 +1982,7 @@ static int qmp_usbc_probe(struct platform_device *pdev)
 
        phy_set_drvdata(qmp->usb_phy, qmp);
 
-       if (qmp->dp_serdes != 0) {
+       if (qmp->dp_serdes) {
                qmp->dp_phy = devm_phy_create(dev, np, &qmp_usbc_dp_phy_ops);
                if (IS_ERR(qmp->dp_phy)) {
                        ret = PTR_ERR(qmp->dp_phy);