]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
mt76: mt7915: fix possible uninitialized pointer dereference in mt7986_wmac_gpio_setup
authorLorenzo Bianconi <lorenzo@kernel.org>
Mon, 4 Apr 2022 08:08:10 +0000 (10:08 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 9 Jun 2022 08:30:11 +0000 (10:30 +0200)
[ Upstream commit 9bd6823f5a64b6465708b244eecc9b7dd4b01bfc ]

Add default case for type switch in mt7986_wmac_gpio_setup routine in
order to avoid a possible uninitialized pointer dereference.

Fixes: 99ad32a4ca3a2 ("mt76: mt7915: add support for MT7986")
Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
Signed-off-by: Felix Fietkau <nbd@nbd.name>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/wireless/mediatek/mt76/mt7915/soc.c

index 3028c02cb840e0df11fa88ed7d4c302f989fd89f..be448d471b03b791bd6d865e87eb594a1cf80d58 100644 (file)
@@ -210,6 +210,8 @@ static int mt7986_wmac_gpio_setup(struct mt7915_dev *dev)
                if (IS_ERR_OR_NULL(state))
                        return -EINVAL;
                break;
+       default:
+               return -EINVAL;
        }
 
        ret = pinctrl_select_state(pinctrl, state);