]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
net: qualcomm: qca_uart: report the consumed byte on RX skb allocation failure
authorPengpeng Hou <pengpeng@iscas.ac.cn>
Thu, 2 Apr 2026 07:12:07 +0000 (15:12 +0800)
committerJakub Kicinski <kuba@kernel.org>
Fri, 3 Apr 2026 22:32:56 +0000 (15:32 -0700)
qca_tty_receive() consumes each input byte before checking whether a
completed frame needs a fresh receive skb. When the current byte completes
a frame, the driver delivers that frame and then allocates a new skb for
the next one.

If that allocation fails, the current code returns i even though data[i]
has already been consumed and may already have completed the delivered
frame. Since serdev interprets the return value as the number of accepted
bytes, this under-reports progress by one byte and can replay the final
byte of the completed frame into a fresh parser state on the next call.

Return i + 1 in that failure path so the accepted-byte count matches the
actual receive-state progress.

Fixes: dfc768fbe618 ("net: qualcomm: add QCA7000 UART driver")
Cc: stable@vger.kernel.org
Signed-off-by: Pengpeng Hou <pengpeng@iscas.ac.cn>
Reviewed-by: Stefan Wahren <wahrenst@gmx.net>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20260402071207.4036-1-pengpeng@iscas.ac.cn
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/qualcomm/qca_uart.c

index 37efb1ea9fcd9ca91067b98b2e2310e9d8881545..847a5f928e41341d451cec75c80312279e3970a0 100644 (file)
@@ -100,7 +100,7 @@ qca_tty_receive(struct serdev_device *serdev, const u8 *data, size_t count)
                        if (!qca->rx_skb) {
                                netdev_dbg(netdev, "recv: out of RX resources\n");
                                n_stats->rx_errors++;
-                               return i;
+                               return i + 1;
                        }
                }
        }