]> git.ipfire.org Git - thirdparty/sqlalchemy/sqlalchemy.git/commitdiff
re-enable these tests
authorMike Bayer <mike_mp@zzzcomputing.com>
Thu, 11 Mar 2010 21:34:13 +0000 (21:34 +0000)
committerMike Bayer <mike_mp@zzzcomputing.com>
Thu, 11 Mar 2010 21:34:13 +0000 (21:34 +0000)
lib/sqlalchemy/dialects/oracle/cx_oracle.py
test/sql/test_returning.py

index d536188da71b514f341fb015ebe2d1c708e8e986..1748a866cb130d84a5ad6162773f60735390b7bb 100644 (file)
@@ -213,7 +213,13 @@ class Oracle_cx_oracleExecutionContext(OracleExecutionContext):
                     del param[fromname]
 
         if self.dialect.auto_setinputsizes:
-            self.set_input_sizes(quoted_bind_names)
+            # cx_oracle really has issues when you setinputsizes 
+            # on String, including that outparams/RETURNING
+            # breaks for varchars
+            self.set_input_sizes(quoted_bind_names, 
+                                     exclude_types=[
+                                              self.dialect.dbapi.STRING, 
+                                              self.dialect.dbapi.UNICODE])
             
         if len(self.compiled_parameters) == 1:
             for key in self.compiled.binds:
index bd0755b9d922d21e2647b48b4a6bd11b393b189d..ba3e2ebb98d7f7466fa400d046afb96173e2c469 100644 (file)
@@ -50,10 +50,8 @@ class ReturningTest(TestBase, AssertsExecutionResults):
         assert row[table.c.persons] == row['persons'] == 5
         assert row[table.c.full] == row['full'] == True
 
-        @testing.fails_on('oracle+cx_oracle', 'unknown DBAPI issue')
-        def test():
-            assert row[table.c.goofy] == row['goofy'] == "FOOsomegoofyBAR"
-        test()
+        eq_(row[table.c.goofy], row['goofy'])
+        eq_(row['goofy'], "FOOsomegoofyBAR")
     
     @testing.fails_on('firebird', "fb can't handle returning x AS y")
     @testing.exclude('firebird', '<', (2, 0), '2.0+ feature')
@@ -66,7 +64,6 @@ class ReturningTest(TestBase, AssertsExecutionResults):
 
     @testing.fails_on('firebird', "fb/kintersbasdb can't handle the bind params")
     @testing.fails_on('oracle+zxjdbc', "JDBC driver bug")
-    @testing.fails_on('oracle+cx_oracle', "unknown DBAPI issue")
     @testing.exclude('firebird', '<', (2, 0), '2.0+ feature')
     @testing.exclude('postgresql', '<', (8, 2), '8.2+ feature')
     def test_anon_expressions(self):