]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
udev: drop redundant log message and fix returned error code
authorYu Watanabe <watanabe.yu+github@gmail.com>
Fri, 26 Oct 2018 23:06:40 +0000 (08:06 +0900)
committerYu Watanabe <watanabe.yu+github@gmail.com>
Tue, 6 Nov 2018 02:15:39 +0000 (11:15 +0900)
src/udev/udev-watch.c
src/udev/udevd.c

index 4924b75c504ef0904401d120f3be504ca00140b0..1d3d9f1c083c171fd8da53a6db26a61c01e7c186 100644 (file)
@@ -24,7 +24,7 @@ static int inotify_fd = -1;
 int udev_watch_init(void) {
         inotify_fd = inotify_init1(IN_CLOEXEC);
         if (inotify_fd < 0)
-                return log_error_errno(errno, "Failed to create inotify descriptor: %m");
+                return -errno;
 
         return inotify_fd;
 }
index 7ec30b92c37a94f231c3eb785fff81488e4a4b4e..42c88781868f2d6a9ec0ce94d29f4325126ab074 100644 (file)
@@ -1578,9 +1578,10 @@ static int manager_new(Manager **ret, int fd_ctrl, int fd_uevent, const char *cg
         if (r < 0)
                 return log_error_errno(r, "could not enable SO_PASSCRED: %m");
 
-        manager->fd_inotify = udev_watch_init();
-        if (manager->fd_inotify < 0)
-                return log_error_errno(ENOMEM, "error initializing inotify");
+        r = udev_watch_init();
+        if (r < 0)
+                return log_error_errno(r, "Failed to create inotify descriptor: %m");
+        manager->fd_inotify = r;
 
         udev_watch_restore();