]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
s4:dsdb: Check return value of ldb_msg_add_empty() (CID 1449667)
authorJoseph Sutton <josephsutton@catalyst.net.nz>
Fri, 6 Oct 2023 01:11:24 +0000 (14:11 +1300)
committerAndrew Bartlett <abartlet@samba.org>
Tue, 17 Oct 2023 03:19:38 +0000 (03:19 +0000)
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
source4/dsdb/samdb/ldb_modules/samba_dsdb.c

index d9de16e02c2a44b9c7b92d522cb0fd3780ec9d72..37213a5febc8742d19e126d8593ded4854402e0f 100644 (file)
@@ -333,8 +333,11 @@ static int samba_dsdb_init(struct ldb_module *module)
                        }
                        features_msg->dn = samba_dsdb_dn;
 
-                       ldb_msg_add_empty(features_msg, SAMBA_COMPATIBLE_FEATURES_ATTR,
-                                         LDB_FLAG_MOD_DELETE, &features_el);
+                       ret = ldb_msg_add_empty(features_msg, SAMBA_COMPATIBLE_FEATURES_ATTR,
+                                               LDB_FLAG_MOD_DELETE, &features_el);
+                       if (ret != LDB_SUCCESS) {
+                               return ret;
+                       }
 
                        if (samba_options_supported == 1) {
                                for (i = 0;