Stop ed25519 8-bit signed left shift overflowing

Standardise usage in ge_scalarmult_base.c for 1 new fix.

diff --git a/src/ext/ed25519/ref10/ge_scalarmult_base.c b/src/ext/ed25519/ref10/ge_scalarmult_base.c
index 3ede0ad177dfb3234f58d8955c8f9147bc1afc53..5292f83221e810e88c583bd4ab4548cca61137b5 100644 (file)
--- a/src/ext/ed25519/ref10/ge_scalarmult_base.c
+++ b/src/ext/ed25519/ref10/ge_scalarmult_base.c
@@ -39,7 +39,7 @@ static void select(ge_precomp *t,int pos,signed char b)
 {
   ge_precomp minust;
   unsigned char bnegative = negative(b);
-  unsigned char babs = b - (((-bnegative) & b) << 1);
+  unsigned char babs = b - SHL8( (-bnegative) & (unsigned char)b, 1);
 
   ge_precomp_0(t);
   cmov(t,&base[pos][0],equal(babs,1));