]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
spi: loopback-test: Do not split 1024-byte hexdumps
authorGeert Uytterhoeven <geert+renesas@glider.be>
Fri, 2 May 2025 11:10:35 +0000 (13:10 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 22 May 2025 12:12:15 +0000 (14:12 +0200)
[ Upstream commit a73fa3690a1f3014d6677e368dce4e70767a6ba2 ]

spi_test_print_hex_dump() prints buffers holding less than 1024 bytes in
full.  Larger buffers are truncated: only the first 512 and the last 512
bytes are printed, separated by a truncation message.  The latter is
confusing in case the buffer holds exactly 1024 bytes, as all data is
printed anyway.

Fix this by printing buffers holding up to and including 1024 bytes in
full.

Fixes: 84e0c4e5e2c4ef42 ("spi: add loopback test driver to allow for spi_master regression tests")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Link: https://patch.msgid.link/37ee1bc90c6554c9347040adabf04188c8f704aa.1746184171.git.geert+renesas@glider.be
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/spi/spi-loopback-test.c

index bbf2015d8e5cceaf3c5b3fe32b81d29f6b3e8609..69b6c87c5525e0c132f2ab34c154ee2fe0d215d4 100644 (file)
@@ -421,7 +421,7 @@ MODULE_LICENSE("GPL");
 static void spi_test_print_hex_dump(char *pre, const void *ptr, size_t len)
 {
        /* limit the hex_dump */
-       if (len < 1024) {
+       if (len <= 1024) {
                print_hex_dump(KERN_INFO, pre,
                               DUMP_PREFIX_OFFSET, 16, 1,
                               ptr, len, 0);