]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/i915/display: Add default case to mipi_exec_send_packet
authorJonathan Cavitt <jonathan.cavitt@intel.com>
Tue, 4 Nov 2025 16:41:51 +0000 (16:41 +0000)
committerJani Nikula <jani.nikula@intel.com>
Thu, 13 Nov 2025 10:02:47 +0000 (12:02 +0200)
Add a default case to the switch case statement in mipi_exec_send_packet
to prevent attempts to read an uninitialized ret value.  It's unlikely
the default case will ever occur during regular exeuction, but if more
MIPI DSI Processor-to-Peripheral transaction types are ever added, then
having this in place will be a useful safety guard.

Signed-off-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
Fixes: 23db1577ce2d ("drm/i915/dsi: log send packet sequence errors")
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
Link: https://patch.msgid.link/20251104164150.16795-2-jonathan.cavitt@intel.com
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
drivers/gpu/drm/i915/display/intel_dsi_vbt.c

index 31edf57a296fc04af935f2c52351c429057570f2..4b815ce6b1fe2156be448472338a764d903571e9 100644 (file)
@@ -171,6 +171,9 @@ static const u8 *mipi_exec_send_packet(struct intel_dsi *intel_dsi,
        case MIPI_DSI_DCS_LONG_WRITE:
                ret = mipi_dsi_dcs_write_buffer(dsi_device, data, len);
                break;
+       default:
+               ret = -EINVAL;
+               break;
        }
 
        if (ret < 0)