]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
gh-105557: Remove duplicate sqlite3 test method (#105558)
authorErlend E. Aasland <erlend.aasland@protonmail.com>
Fri, 9 Jun 2023 13:36:59 +0000 (15:36 +0200)
committerGitHub <noreply@github.com>
Fri, 9 Jun 2023 13:36:59 +0000 (15:36 +0200)
test_func_return_too_large_int() was defined twice.
Keep only the redefined method, as that also checks the tracebacks.

Lib/test/test_sqlite3/test_userfunctions.py

index 632d657d416fd4f5001ace800d71e7151d2be6d1..03d27531666c891fc8c0052e973cc5740c689e43 100644 (file)
@@ -195,7 +195,6 @@ class FunctionTests(unittest.TestCase):
         self.con.create_function("returnblob", 0, func_returnblob)
         self.con.create_function("returnlonglong", 0, func_returnlonglong)
         self.con.create_function("returnnan", 0, lambda: float("nan"))
-        self.con.create_function("returntoolargeint", 0, lambda: 1 << 65)
         self.con.create_function("return_noncont_blob", 0,
                                  lambda: memoryview(b"blob")[::2])
         self.con.create_function("raiseexception", 0, func_raiseexception)
@@ -294,11 +293,6 @@ class FunctionTests(unittest.TestCase):
         cur.execute("select returnnan()")
         self.assertIsNone(cur.fetchone()[0])
 
-    def test_func_return_too_large_int(self):
-        cur = self.con.cursor()
-        self.assertRaisesRegex(sqlite.DataError, "string or blob too big",
-                               self.con.execute, "select returntoolargeint()")
-
     @with_tracebacks(ZeroDivisionError, name="func_raiseexception")
     def test_func_exception(self):
         cur = self.con.cursor()
@@ -444,9 +438,10 @@ class FunctionTests(unittest.TestCase):
     @with_tracebacks(OverflowError)
     def test_func_return_too_large_int(self):
         cur = self.con.cursor()
+        msg = "string or blob too big"
         for value in 2**63, -2**63-1, 2**64:
             self.con.create_function("largeint", 0, lambda value=value: value)
-            with self.assertRaises(sqlite.DataError):
+            with self.assertRaisesRegex(sqlite.DataError, msg):
                 cur.execute("select largeint()")
 
     @with_tracebacks(UnicodeEncodeError, "surrogates not allowed", "chr")