]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
ctdb-scripts: Drop TCP tuning comments from statd_callout_helper
authorMartin Schwenke <mschwenke@ddn.com>
Wed, 16 Oct 2024 01:23:42 +0000 (12:23 +1100)
committerAmitay Isaacs <amitay@samba.org>
Fri, 13 Dec 2024 13:57:32 +0000 (13:57 +0000)
Commits caad5dc38d790d76f6720b312c1557ec3151a084 and
f022df1d40c9c1e3e528f178204f404ee395d5c2 commented out these lines
back in 2007.

2 things are clear from the commit messages:

* These setting should not be required in the real world - they are:

    mainly useful for avoiding ack-storms when doing very rapid
    failover/failback during testing

* If they are needed, they are not specific to
  statd_callout/statd_callout_helper

Let's remove these comments to avoid confusing people.

Reported-by: Ulrich Sibiller <ulrich.sibiller@eviden.com>
Signed-off-by: Martin Schwenke <mschwenke@ddn.com>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
ctdb/tools/statd_callout_helper

index a6ceb56aab96959fa19494d032fbd14fc7e7a30d..7bf747d1b250547316da3293d96395fd5230e099 100755 (executable)
@@ -207,12 +207,6 @@ notify)
        # conflicting locks through other nodes before all locks have been
        # reclaimed)
 
-       # we need these settings to make sure that no tcp connections survive
-       # across a very fast failover/failback
-       #echo 10 > /proc/sys/net/ipv4/tcp_fin_timeout
-       #echo 0 > /proc/sys/net/ipv4/tcp_max_tw_buckets
-       #echo 0 > /proc/sys/net/ipv4/tcp_max_orphans
-
        # Delete the notification list for statd, we don't want it to
        # ping any clients
        dir=$(find_statd_sm_dir)