Fix a copy-and-paste issue found by coverity

Fixes CID 980650; bugfix on 0.2.4.10-alpha.

diff --git a/changes/cov980650 b/changes/cov980650
new file mode 100644 (file)
index 0000000..cbbada2
--- /dev/null
+++ b/changes/cov980650
@@ -0,0 +1,4 @@
+  o Minor bugfixes:
+    - Fix a copy-and-paste error when adding a missing A1 to a routerset
+      because of GeoIPExcludeUnknown. Fix for coverity CID 980650.
+      Bugfix on 0.2.4.10-alpha.

diff --git a/src/or/routerset.c b/src/or/routerset.c
index e45516bb6cd453d6734241818fd16f107c45346e..1eca5b6f6fddaef0f0026f3a29de422e3f5fe398 100644 (file)
--- a/src/or/routerset.c
+++ b/src/or/routerset.c
@@ -255,7 +255,7 @@ routerset_add_unknown_ccs(routerset_t **setp, int only_if_some_cc_set)
   }
   if (add_a1) {
     smartlist_add(set->country_names, tor_strdup("a1"));
-    smartlist_add(set->country_names, tor_strdup("{a1}"));
+    smartlist_add(set->list, tor_strdup("{a1}"));
   }
 
   if (add_unknown || add_a1) {