]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
drivers: android: correct the size of struct binder_uintptr_t for BC_DEAD_BINDER_DONE
authorLisa Du <cldu@marvell.com>
Wed, 17 Feb 2016 01:32:52 +0000 (09:32 +0800)
committerLuis Henriques <luis.henriques@canonical.com>
Tue, 8 Mar 2016 12:15:26 +0000 (12:15 +0000)
commit 7a64cd887fdb97f074c3fda03bee0bfb9faceac3 upstream.

There's one point was missed in the patch commit da49889deb34 ("staging:
binder: Support concurrent 32 bit and 64 bit processes."). When configure
BINDER_IPC_32BIT, the size of binder_uintptr_t was 32bits, but size of
void * is 64bit on 64bit system. Correct it here.

Signed-off-by: Lisa Du <cldu@marvell.com>
Signed-off-by: Nicolas Boichat <drinkcat@chromium.org>
Fixes: da49889deb34 ("staging: binder: Support concurrent 32 bit and 64 bit processes.")
Acked-by: Olof Johansson <olof@lixom.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
[ luis: backported to 3.16:
  - binder is still in staging in the 3.16 kernel]
Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
drivers/staging/android/binder.c

index a741da77828aec517d858b1644be4102d2298749..3b79624703a750156d78573a00f4ebc1f9d99f63 100644 (file)
@@ -2049,7 +2049,7 @@ static int binder_thread_write(struct binder_proc *proc,
                        if (get_user(cookie, (binder_uintptr_t __user *)ptr))
                                return -EFAULT;
 
-                       ptr += sizeof(void *);
+                       ptr += sizeof(cookie);
                        list_for_each_entry(w, &proc->delivered_death, entry) {
                                struct binder_ref_death *tmp_death = container_of(w, struct binder_ref_death, work);