]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
winbind: Fix CID 1455915 Resource leak
authorVolker Lendecke <vl@samba.org>
Tue, 19 Nov 2019 13:20:14 +0000 (14:20 +0100)
committerAndreas Schneider <asn@cryptomilk.org>
Tue, 19 Nov 2019 16:13:36 +0000 (16:13 +0000)
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
source3/winbindd/winbindd_cache.c

index 3e7afdaa546335a37d28253f36e7d01c00f6adbe..9122e2bc5d691e650cc7d0a244f8320e85e87d28 100644 (file)
@@ -1392,17 +1392,20 @@ NTSTATUS wcache_save_creds(struct winbindd_domain *domain,
 
        rc = gnutls_hash_init(&hash_hnd, GNUTLS_DIG_MD5);
        if (rc < 0) {
+               centry_free(centry);
                return gnutls_error_to_ntstatus(rc, NT_STATUS_HASH_NOT_SUPPORTED);
        }
 
        rc = gnutls_hash(hash_hnd, cred_salt, 16);
        if (rc < 0) {
                gnutls_hash_deinit(hash_hnd, NULL);
+               centry_free(centry);
                return gnutls_error_to_ntstatus(rc, NT_STATUS_HASH_NOT_SUPPORTED);
        }
        rc = gnutls_hash(hash_hnd, nt_pass, 16);
        if (rc < 0) {
                gnutls_hash_deinit(hash_hnd, NULL);
+               centry_free(centry);
                return gnutls_error_to_ntstatus(rc, NT_STATUS_HASH_NOT_SUPPORTED);
        }
        gnutls_hash_deinit(hash_hnd, salted_hash);