talloc/testsuite: Fix CID 1291641 - Logically dead code

Add check for snprintf return code.

Signed-off-by: Robin Hack <hack.robin@gmail.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>

diff --git a/lib/talloc/testsuite.c b/lib/talloc/testsuite.c
index 34410b81c3f3a12b262e9dd02a8174a0a89d5715..5eab839f51d3c395aef06d3e87d79e71ed203a41 100644 (file)
--- a/lib/talloc/testsuite.c
+++ b/lib/talloc/testsuite.c
@@ -1795,11 +1795,11 @@ static bool test_pthread_talloc_passing(void)
         * They will use their own toplevel contexts.
         */
        for (i = 0; i < NUM_THREADS; i++) {
-               (void)snprintf(str_array[i],
-                               20,
-                               "thread:%d",
-                               i);
-               if (str_array[i] == NULL) {
+               ret = snprintf(str_array[i],
+                              20,
+                              "thread:%d",
+                              i);
+               if (ret < 0) {
                        printf("snprintf %d failed\n", i);
                        return false;
                }