]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
bpo-40798: Generate a different message for already removed elements (GH-20483)
authorMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Sat, 30 May 2020 07:54:58 +0000 (00:54 -0700)
committerGitHub <noreply@github.com>
Sat, 30 May 2020 07:54:58 +0000 (00:54 -0700)
(cherry picked from commit 735d902b363b759df9ff00e58bbf4f7e2bde78cd)

Co-authored-by: Florian Dahlitz <f2dahlitz@freenet.de>
Doc/tools/extensions/pyspecific.py
Doc/tools/templates/dummy.html

index 2d956124159420946feb4a3011f528c8f6874288..a128c705847e940ab13d870128fb7a2da0c61886 100644 (file)
@@ -311,7 +311,8 @@ class DeprecatedRemoved(Directive):
     final_argument_whitespace = True
     option_spec = {}
 
-    _label = 'Deprecated since version {deprecated}, will be removed in version {removed}'
+    _deprecated_label = 'Deprecated since version {deprecated}, will be removed in version {removed}'
+    _removed_label = 'Deprecated since version {deprecated}, removed in version {removed}'
 
     def run(self):
         node = addnodes.versionmodified()
@@ -319,7 +320,15 @@ class DeprecatedRemoved(Directive):
         node['type'] = 'deprecated-removed'
         version = (self.arguments[0], self.arguments[1])
         node['version'] = version
-        label = translators['sphinx'].gettext(self._label)
+        env = self.state.document.settings.env
+        current_version = tuple(int(e) for e in env.config.version.split('.'))
+        removed_version = tuple(int(e) for e in self.arguments[1].split('.'))
+        if current_version < removed_version:
+            label = self._deprecated_label
+        else:
+            label = self._removed_label
+
+        label = translators['sphinx'].gettext(label)
         text = label.format(deprecated=self.arguments[0], removed=self.arguments[1])
         if len(self.arguments) == 3:
             inodes, messages = self.state.inline_text(self.arguments[2],
index 8d94137b01b5192096abfff8bb9568eaeae01e87..68ae3ad148ec2733a50ab9b5ec915a0d45db6e04 100644 (file)
@@ -5,3 +5,4 @@ In extensions/pyspecific.py:
 
 {% trans %}CPython implementation detail:{% endtrans %}
 {% trans %}Deprecated since version {deprecated}, will be removed in version {removed}{% endtrans %}
+{% trans %}Deprecated since version {deprecated}, removed in version {removed}{% endtrans %}