]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
dsdb: Avoid search on * in replmd_replicated_apply_next()
authorAndrew Bartlett <abartlet@samba.org>
Fri, 8 Jul 2016 19:47:15 +0000 (07:47 +1200)
committerGarming Sam <garming@samba.org>
Tue, 12 Jul 2016 21:24:13 +0000 (23:24 +0200)
A search on * can be quite expensive if we have to post-process any of the results

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
source4/dsdb/samdb/ldb_modules/repl_meta_data.c

index 9a1ff166b30db7df0e1d3d953ffd163277f25794..c6dc6c663fe1fb4d9fa482c0554cfdf794d5f396 100644 (file)
@@ -5296,9 +5296,10 @@ static int replmd_replicated_apply_next(struct replmd_replicated_request *ar)
        char *tmp_str;
        char *filter;
        struct ldb_request *search_req;
-       static const char *attrs[] = { "*", "parentGUID", "instanceType",
+       static const char *attrs[] = { "repsFrom", "replUpToDateVector",
+                                      "parentGUID", "instanceType",
                                       "replPropertyMetaData", "nTSecurityDescriptor",
-                                      NULL };
+                                      "isDeleted", NULL };
        struct GUID_txt_buf guid_str_buf;
 
        if (ar->index_current >= ar->objs->num_objects) {