e2fsck: fix spurious duplicate directory entries with encrypted filenames

Use memcmp() instead of strncmp() since encrypted directory names can
contain NUL characters.  For non-encrypted directories, we've already
checked for the case of NUL characters in file names, so it's safe to
use memcmp() here in all cases.

Signed-off-by: Theodore Ts'o <tytso@mit.edu>

diff --git a/e2fsck/pass2.c b/e2fsck/pass2.c
index 33e4854615d3141c87773ad2b28e2d133958d05f..a6624f4d9c91d3725b0cbbb74830b49236febd65 100644 (file)
--- a/e2fsck/pass2.c
+++ b/e2fsck/pass2.c
@@ -314,7 +314,7 @@ static int dict_de_cmp(const void *a, const void *b)
        if (a_len != b_len)
                return (a_len - b_len);
 
-       return strncmp(de_a->name, de_b->name, a_len);
+       return memcmp(de_a->name, de_b->name, a_len);
 }
 
 /*