]> git.ipfire.org Git - thirdparty/squid.git/commitdiff
Ssl::CertValidationHelper::sslSubmit: Assure that the callback->getDialer()
authorChristos Tsantilas <chtsanti@users.sourceforge.net>
Tue, 5 Jan 2016 11:02:19 +0000 (13:02 +0200)
committerChristos Tsantilas <chtsanti@users.sourceforge.net>
Tue, 5 Jan 2016 11:02:19 +0000 (13:02 +0200)
return non NULL before use the result

Detected by Coverity Scan. Issue 1346998

src/ssl/helper.cc

index 852c2f522f49a504f687580571fdbe633645fe81..bd0bf6134b5729f384c9f352f198ee0a6aa0353a 100644 (file)
@@ -259,6 +259,7 @@ void Ssl::CertValidationHelper::sslSubmit(Ssl::CertValidationRequest const &requ
             (validationResponse = CertValidationHelper::HelperCache->get(crtdvdData->query.c_str()))) {
 
         CertValidationHelper::CbDialer *dialer = dynamic_cast<CertValidationHelper::CbDialer*>(callback->getDialer());
+        Must(dialer);
         dialer->arg1 = *validationResponse;
         ScheduleCallHere(callback);
         SSL_free(crtdvdData->ssl);
@@ -270,6 +271,7 @@ void Ssl::CertValidationHelper::sslSubmit(Ssl::CertValidationRequest const &requ
         Ssl::CertValidationResponse::Pointer resp = new Ssl::CertValidationResponse;;
         resp->resultCode = ::Helper::BrokenHelper;
         Ssl::CertValidationHelper::CbDialer *dialer = dynamic_cast<Ssl::CertValidationHelper::CbDialer*>(callback->getDialer());
+        Must(dialer);
         dialer->arg1 = resp;
         ScheduleCallHere(callback);