]> git.ipfire.org Git - thirdparty/vim.git/commitdiff
patch 9.1.1659: configure: uses AC_INIT without args v9.1.1659
authorDamien Lejay <damien@lejay.be>
Wed, 20 Aug 2025 19:29:54 +0000 (21:29 +0200)
committerChristian Brabandt <cb@256bit.org>
Wed, 20 Aug 2025 19:29:54 +0000 (21:29 +0200)
Problem:  configure: uses AC_INIT without args
Solution: Add a comment explaining why AC_INIT has no args
          (Damien Lejay)

closes: #18053

Signed-off-by: Damien Lejay <damien@lejay.be>
Signed-off-by: Christian Brabandt <cb@256bit.org>
src/configure.ac
src/version.c

index cdb818519981984d27a7d6b4389189446af010fd..4fe439f89e344627bbf9b49bc606140b48f405a7 100644 (file)
@@ -2,6 +2,15 @@ dnl configure.ac: autoconf script for Vim
 
 dnl Process this file with autoconf 2.72 to produce "configure".
 
+dnl Normally, AC_INIT([package],[version],[bug-report],[tarname],[url])
+dnl provides PACKAGE_* macros, used by Autoconf on UNIX to inject version
+dnl info into config.h, --version output, and "make dist".
+dnl
+dnl Vim does not rely on that: versioning is centralized in version.h/version.c,
+dnl which ensures a single cross-platform source of truth for both UNIX and
+dnl non-UNIX platforms.
+dnl
+dnl Therefore we call AC_INIT without arguments.
 AC_INIT
 AC_CONFIG_SRCDIR([vim.h])
 AC_CONFIG_HEADERS(auto/config.h:config.h.in)
@@ -2344,7 +2353,7 @@ AC_MSG_CHECKING(--enable-socketserver argument)
 AC_ARG_ENABLE(socketserver,
        [  --enable-socketserver Use sockets for clientserver communication.],
        [enable_socketserver=$enableval],
-       AS_IF([test "x$features" = xtiny], 
+       AS_IF([test "x$features" = xtiny],
                        [enable_socketserver=no_auto
                         AC_MSG_RESULT([cannot use socketserver with tiny features])],
                        [enable_socketserver=auto]))
index 4d2aa59ccc3fc683ec587105a7564b72ed9eba84..b0cc80277c99eaaaf2780dddeb26d9ec7ac58002 100644 (file)
@@ -724,6 +724,8 @@ static char *(features[]) =
 
 static int included_patches[] =
 {   /* Add new patch number below this line */
+/**/
+    1659,
 /**/
     1658,
 /**/