]> git.ipfire.org Git - thirdparty/zstd.git/commitdiff
correct mmap error check
authorrichardsonnick <nic.rr@icloud.com>
Tue, 23 Dec 2025 21:40:02 +0000 (16:40 -0500)
committerNick Terrell <nickrterrell@gmail.com>
Fri, 27 Feb 2026 22:40:26 +0000 (17:40 -0500)
Update mmap error validation to check for MAP_FAILED instead of NULL.
POSIX specifies that mmap returns MAP_FAILED (-1) on failure.

programs/fileio.c

index 4000c5b62f49ad8bd3ef228f8f56ccdf3afaac8f..a0dcad817458e140e16589e34ef31f94db6f2571 100644 (file)
@@ -1050,7 +1050,9 @@ static size_t FIO_setDictBufferMMap(FIO_Dict_t* dict, const char* fileName, FIO_
     }
 
     *bufferPtr = mmap(NULL, (size_t)fileSize, PROT_READ, MAP_PRIVATE, fileHandle, 0);
-    if (*bufferPtr==NULL) EXM_THROW(34, "%s", strerror(errno));
+    if (*bufferPtr == MAP_FAILED) {
+      EXM_THROW(34, "%s", strerror(errno))
+    }
 
     close(fileHandle);
     return (size_t)fileSize;