]> git.ipfire.org Git - thirdparty/kernel/stable-queue.git/commitdiff
4.19-stable patches
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 21 Apr 2020 14:37:26 +0000 (16:37 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 21 Apr 2020 14:37:26 +0000 (16:37 +0200)
added patches:
arm-bpf-fix-bugs-with-alu64-rsh-arsh-bpf_k-shift-by-0.patch
ext4-use-non-movable-memory-for-superblock-readahead.patch
watchdog-sp805-fix-restart-handler.patch

queue-4.19/alsa-hda-honor-pm-disablement-in-pm-freeze-and-thaw_noirq-ops.patch [deleted file]
queue-4.19/arm-bpf-fix-bugs-with-alu64-rsh-arsh-bpf_k-shift-by-0.patch [new file with mode: 0644]
queue-4.19/ext4-use-non-movable-memory-for-superblock-readahead.patch [new file with mode: 0644]
queue-4.19/series
queue-4.19/watchdog-sp805-fix-restart-handler.patch [new file with mode: 0644]

diff --git a/queue-4.19/alsa-hda-honor-pm-disablement-in-pm-freeze-and-thaw_noirq-ops.patch b/queue-4.19/alsa-hda-honor-pm-disablement-in-pm-freeze-and-thaw_noirq-ops.patch
deleted file mode 100644 (file)
index 8bdcf27..0000000
+++ /dev/null
@@ -1,43 +0,0 @@
-From 10db5bccc390e8e4bd9fcd1fbd4f1b23f271a405 Mon Sep 17 00:00:00 2001
-From: Takashi Iwai <tiwai@suse.de>
-Date: Mon, 13 Apr 2020 10:20:30 +0200
-Subject: ALSA: hda: Honor PM disablement in PM freeze and thaw_noirq ops
-
-From: Takashi Iwai <tiwai@suse.de>
-
-commit 10db5bccc390e8e4bd9fcd1fbd4f1b23f271a405 upstream.
-
-freeze_noirq and thaw_noirq need to check the PM availability like
-other PM ops.  There are cases where the device got disabled due to
-the error, and the PM operation should be ignored for that.
-
-Fixes: 3e6db33aaf1d ("ALSA: hda - Set SKL+ hda controller power at freeze() and thaw()")
-BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=207043
-Link: https://lore.kernel.org/r/20200413082034.25166-3-tiwai@suse.de
-Signed-off-by: Takashi Iwai <tiwai@suse.de>
-Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
----
- sound/pci/hda/hda_intel.c |    4 ++++
- 1 file changed, 4 insertions(+)
-
---- a/sound/pci/hda/hda_intel.c
-+++ b/sound/pci/hda/hda_intel.c
-@@ -1129,6 +1129,8 @@ static int azx_freeze_noirq(struct devic
-       struct azx *chip = card->private_data;
-       struct pci_dev *pci = to_pci_dev(dev);
-+      if (!azx_is_pm_ready(card))
-+              return 0;
-       if (chip->driver_type == AZX_DRIVER_SKL)
-               pci_set_power_state(pci, PCI_D3hot);
-@@ -1141,6 +1143,8 @@ static int azx_thaw_noirq(struct device
-       struct azx *chip = card->private_data;
-       struct pci_dev *pci = to_pci_dev(dev);
-+      if (!azx_is_pm_ready(card))
-+              return 0;
-       if (chip->driver_type == AZX_DRIVER_SKL)
-               pci_set_power_state(pci, PCI_D0);
diff --git a/queue-4.19/arm-bpf-fix-bugs-with-alu64-rsh-arsh-bpf_k-shift-by-0.patch b/queue-4.19/arm-bpf-fix-bugs-with-alu64-rsh-arsh-bpf_k-shift-by-0.patch
new file mode 100644 (file)
index 0000000..f0d3b10
--- /dev/null
@@ -0,0 +1,63 @@
+From bb9562cf5c67813034c96afb50bd21130a504441 Mon Sep 17 00:00:00 2001
+From: Luke Nelson <lukenels@cs.washington.edu>
+Date: Wed, 8 Apr 2020 18:12:29 +0000
+Subject: arm, bpf: Fix bugs with ALU64 {RSH, ARSH} BPF_K shift by 0
+
+From: Luke Nelson <lukenels@cs.washington.edu>
+
+commit bb9562cf5c67813034c96afb50bd21130a504441 upstream.
+
+The current arm BPF JIT does not correctly compile RSH or ARSH when the
+immediate shift amount is 0. This causes the "rsh64 by 0 imm" and "arsh64
+by 0 imm" BPF selftests to hang the kernel by reaching an instruction
+the verifier determines to be unreachable.
+
+The root cause is in how immediate right shifts are encoded on arm.
+For LSR and ASR (logical and arithmetic right shift), a bit-pattern
+of 00000 in the immediate encodes a shift amount of 32. When the BPF
+immediate is 0, the generated code shifts by 32 instead of the expected
+behavior (a no-op).
+
+This patch fixes the bugs by adding an additional check if the BPF
+immediate is 0. After the change, the above mentioned BPF selftests pass.
+
+Fixes: 39c13c204bb11 ("arm: eBPF JIT compiler")
+Co-developed-by: Xi Wang <xi.wang@gmail.com>
+Signed-off-by: Xi Wang <xi.wang@gmail.com>
+Signed-off-by: Luke Nelson <luke.r.nels@gmail.com>
+Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
+Link: https://lore.kernel.org/bpf/20200408181229.10909-1-luke.r.nels@gmail.com
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+
+---
+ arch/arm/net/bpf_jit_32.c |   12 ++++++++++--
+ 1 file changed, 10 insertions(+), 2 deletions(-)
+
+--- a/arch/arm/net/bpf_jit_32.c
++++ b/arch/arm/net/bpf_jit_32.c
+@@ -930,7 +930,11 @@ static inline void emit_a32_rsh_i64(cons
+       rd = arm_bpf_get_reg64(dst, tmp, ctx);
+       /* Do LSR operation */
+-      if (val < 32) {
++      if (val == 0) {
++              /* An immediate value of 0 encodes a shift amount of 32
++               * for LSR. To shift by 0, don't do anything.
++               */
++      } else if (val < 32) {
+               emit(ARM_MOV_SI(tmp2[1], rd[1], SRTYPE_LSR, val), ctx);
+               emit(ARM_ORR_SI(rd[1], tmp2[1], rd[0], SRTYPE_ASL, 32 - val), ctx);
+               emit(ARM_MOV_SI(rd[0], rd[0], SRTYPE_LSR, val), ctx);
+@@ -956,7 +960,11 @@ static inline void emit_a32_arsh_i64(con
+       rd = arm_bpf_get_reg64(dst, tmp, ctx);
+       /* Do ARSH operation */
+-      if (val < 32) {
++      if (val == 0) {
++              /* An immediate value of 0 encodes a shift amount of 32
++               * for ASR. To shift by 0, don't do anything.
++               */
++      } else if (val < 32) {
+               emit(ARM_MOV_SI(tmp2[1], rd[1], SRTYPE_LSR, val), ctx);
+               emit(ARM_ORR_SI(rd[1], tmp2[1], rd[0], SRTYPE_ASL, 32 - val), ctx);
+               emit(ARM_MOV_SI(rd[0], rd[0], SRTYPE_ASR, val), ctx);
diff --git a/queue-4.19/ext4-use-non-movable-memory-for-superblock-readahead.patch b/queue-4.19/ext4-use-non-movable-memory-for-superblock-readahead.patch
new file mode 100644 (file)
index 0000000..c6c6bcb
--- /dev/null
@@ -0,0 +1,107 @@
+From d87f639258a6a5980183f11876c884931ad93da2 Mon Sep 17 00:00:00 2001
+From: Roman Gushchin <guro@fb.com>
+Date: Fri, 28 Feb 2020 16:14:11 -0800
+Subject: ext4: use non-movable memory for superblock readahead
+
+From: Roman Gushchin <guro@fb.com>
+
+commit d87f639258a6a5980183f11876c884931ad93da2 upstream.
+
+Since commit a8ac900b8163 ("ext4: use non-movable memory for the
+superblock") buffers for ext4 superblock were allocated using
+the sb_bread_unmovable() helper which allocated buffer heads
+out of non-movable memory blocks. It was necessarily to not block
+page migrations and do not cause cma allocation failures.
+
+However commit 85c8f176a611 ("ext4: preload block group descriptors")
+broke this by introducing pre-reading of the ext4 superblock.
+The problem is that __breadahead() is using __getblk() underneath,
+which allocates buffer heads out of movable memory.
+
+It resulted in page migration failures I've seen on a machine
+with an ext4 partition and a preallocated cma area.
+
+Fix this by introducing sb_breadahead_unmovable() and
+__breadahead_gfp() helpers which use non-movable memory for buffer
+head allocations and use them for the ext4 superblock readahead.
+
+Reviewed-by: Andreas Dilger <adilger@dilger.ca>
+Fixes: 85c8f176a611 ("ext4: preload block group descriptors")
+Signed-off-by: Roman Gushchin <guro@fb.com>
+Link: https://lore.kernel.org/r/20200229001411.128010-1-guro@fb.com
+Signed-off-by: Theodore Ts'o <tytso@mit.edu>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+
+---
+ fs/buffer.c                 |   11 +++++++++++
+ fs/ext4/inode.c             |    2 +-
+ fs/ext4/super.c             |    2 +-
+ include/linux/buffer_head.h |    8 ++++++++
+ 4 files changed, 21 insertions(+), 2 deletions(-)
+
+--- a/fs/buffer.c
++++ b/fs/buffer.c
+@@ -1336,6 +1336,17 @@ void __breadahead(struct block_device *b
+ }
+ EXPORT_SYMBOL(__breadahead);
++void __breadahead_gfp(struct block_device *bdev, sector_t block, unsigned size,
++                    gfp_t gfp)
++{
++      struct buffer_head *bh = __getblk_gfp(bdev, block, size, gfp);
++      if (likely(bh)) {
++              ll_rw_block(REQ_OP_READ, REQ_RAHEAD, 1, &bh);
++              brelse(bh);
++      }
++}
++EXPORT_SYMBOL(__breadahead_gfp);
++
+ /**
+  *  __bread_gfp() - reads a specified block and returns the bh
+  *  @bdev: the block_device to read from
+--- a/fs/ext4/inode.c
++++ b/fs/ext4/inode.c
+@@ -4690,7 +4690,7 @@ make_io:
+                       if (end > table)
+                               end = table;
+                       while (b <= end)
+-                              sb_breadahead(sb, b++);
++                              sb_breadahead_unmovable(sb, b++);
+               }
+               /*
+--- a/fs/ext4/super.c
++++ b/fs/ext4/super.c
+@@ -4207,7 +4207,7 @@ static int ext4_fill_super(struct super_
+       /* Pre-read the descriptors into the buffer cache */
+       for (i = 0; i < db_count; i++) {
+               block = descriptor_loc(sb, logical_sb_block, i);
+-              sb_breadahead(sb, block);
++              sb_breadahead_unmovable(sb, block);
+       }
+       for (i = 0; i < db_count; i++) {
+--- a/include/linux/buffer_head.h
++++ b/include/linux/buffer_head.h
+@@ -189,6 +189,8 @@ struct buffer_head *__getblk_gfp(struct
+ void __brelse(struct buffer_head *);
+ void __bforget(struct buffer_head *);
+ void __breadahead(struct block_device *, sector_t block, unsigned int size);
++void __breadahead_gfp(struct block_device *, sector_t block, unsigned int size,
++                gfp_t gfp);
+ struct buffer_head *__bread_gfp(struct block_device *,
+                               sector_t block, unsigned size, gfp_t gfp);
+ void invalidate_bh_lrus(void);
+@@ -319,6 +321,12 @@ sb_breadahead(struct super_block *sb, se
+       __breadahead(sb->s_bdev, block, sb->s_blocksize);
+ }
++static inline void
++sb_breadahead_unmovable(struct super_block *sb, sector_t block)
++{
++      __breadahead_gfp(sb->s_bdev, block, sb->s_blocksize, 0);
++}
++
+ static inline struct buffer_head *
+ sb_getblk(struct super_block *sb, sector_t block)
+ {
index 132426f5008f868eed76fdc12bebdefbfc26580d..71d57844f1f28627b0debe0748a83401c823c838 100644 (file)
@@ -1,4 +1,6 @@
 arm-bpf-fix-offset-overflow-for-bpf_mem-bpf_dw.patch
 objtool-fix-switch-table-detection-in-.text.unlikely.patch
 scsi-sg-add-sg_remove_request-in-sg_common_write.patch
-alsa-hda-honor-pm-disablement-in-pm-freeze-and-thaw_noirq-ops.patch
+ext4-use-non-movable-memory-for-superblock-readahead.patch
+watchdog-sp805-fix-restart-handler.patch
+arm-bpf-fix-bugs-with-alu64-rsh-arsh-bpf_k-shift-by-0.patch
diff --git a/queue-4.19/watchdog-sp805-fix-restart-handler.patch b/queue-4.19/watchdog-sp805-fix-restart-handler.patch
new file mode 100644 (file)
index 0000000..6fde358
--- /dev/null
@@ -0,0 +1,44 @@
+From ea104a9e4d3e9ebc26fb78dac35585b142ee288b Mon Sep 17 00:00:00 2001
+From: Michael Walle <michael@walle.cc>
+Date: Fri, 27 Mar 2020 17:24:50 +0100
+Subject: watchdog: sp805: fix restart handler
+
+From: Michael Walle <michael@walle.cc>
+
+commit ea104a9e4d3e9ebc26fb78dac35585b142ee288b upstream.
+
+The restart handler is missing two things, first, the registers
+has to be unlocked and second there is no synchronization for the
+write_relaxed() calls.
+
+This was tested on a custom board with the NXP LS1028A SoC.
+
+Fixes: 6c5c0d48b686c ("watchdog: sp805: add restart handler")
+Signed-off-by: Michael Walle <michael@walle.cc>
+Reviewed-by: Guenter Roeck <linux@roeck-us.net>
+Link: https://lore.kernel.org/r/20200327162450.28506-1-michael@walle.cc
+Signed-off-by: Guenter Roeck <linux@roeck-us.net>
+Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+
+---
+ drivers/watchdog/sp805_wdt.c |    4 ++++
+ 1 file changed, 4 insertions(+)
+
+--- a/drivers/watchdog/sp805_wdt.c
++++ b/drivers/watchdog/sp805_wdt.c
+@@ -137,10 +137,14 @@ wdt_restart(struct watchdog_device *wdd,
+ {
+       struct sp805_wdt *wdt = watchdog_get_drvdata(wdd);
++      writel_relaxed(UNLOCK, wdt->base + WDTLOCK);
+       writel_relaxed(0, wdt->base + WDTCONTROL);
+       writel_relaxed(0, wdt->base + WDTLOAD);
+       writel_relaxed(INT_ENABLE | RESET_ENABLE, wdt->base + WDTCONTROL);
++      /* Flush posted writes. */
++      readl_relaxed(wdt->base + WDTLOCK);
++
+       return 0;
+ }