Issue #19788: kill_python(_d).exe is now run as a PreBuildEvent on the

pythoncore sub-project.  This should prevent build errors due a previous
build's python(_d).exe still running.

diff --git a/Misc/NEWS b/Misc/NEWS
index 3a331e81516e9047343c835628ea87e6f9084447..59db14f3e2d2ff0dbcffce9f6a20d9deb5f15c1b 100644 (file)
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -92,6 +92,10 @@ Documentation
 Build
 -----
 
+- Issue #19788: kill_python(_d).exe is now run as a PreBuildEvent on the
+  pythoncore sub-project.  This should prevent build errors due a previous
+  build's python(_d).exe still running.
+
 - Add workaround for VS 2010 nmake clean issue. VS 2010 doesn't set up PATH
   for nmake.exe correctly.
 

diff --git a/PCbuild/pythoncore.vcxproj b/PCbuild/pythoncore.vcxproj
index 29493e399b73c963160a7c0f69f17ea3b2c7f639..89a63d101543bc4462d5c20f422ed25a78c6c962 100644 (file)
--- a/PCbuild/pythoncore.vcxproj
+++ b/PCbuild/pythoncore.vcxproj
@@ -181,6 +181,12 @@
       <IgnoreSpecificDefaultLibraries>libc;%(IgnoreSpecificDefaultLibraries)</IgnoreSpecificDefaultLibraries>
       <BaseAddress>0x1e000000</BaseAddress>
     </Link>
+    <PreBuildEvent>
+      <Command>$(KillPythonExe)</Command>
+    </PreBuildEvent>
+    <PreBuildEvent>
+      <Message>Killing any running $(PythonExe) instances...</Message>
+    </PreBuildEvent>
   </ItemDefinitionGroup>
   <ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Release|x64'">
     <Midl>
@@ -206,6 +212,12 @@
       <IgnoreSpecificDefaultLibraries>libc;%(IgnoreSpecificDefaultLibraries)</IgnoreSpecificDefaultLibraries>
       <BaseAddress>0x1e000000</BaseAddress>
     </Link>
+    <PreBuildEvent>
+      <Command>$(KillPythonExe)</Command>
+    </PreBuildEvent>
+    <PreBuildEvent>
+      <Message>Killing any running $(PythonExe) instances...</Message>
+    </PreBuildEvent>
   </ItemDefinitionGroup>
   <ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'">
     <ClCompile>
@@ -231,6 +243,12 @@
       <IgnoreSpecificDefaultLibraries>libc;%(IgnoreSpecificDefaultLibraries)</IgnoreSpecificDefaultLibraries>
       <BaseAddress>0x1e000000</BaseAddress>
     </Link>
+    <PreBuildEvent>
+      <Command>$(KillPythonExe)</Command>
+    </PreBuildEvent>
+    <PreBuildEvent>
+      <Message>Killing any running $(PythonExe) instances...</Message>
+    </PreBuildEvent>
   </ItemDefinitionGroup>
   <ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Debug|x64'">
     <Midl>
@@ -259,6 +277,12 @@
       <IgnoreSpecificDefaultLibraries>libc;%(IgnoreSpecificDefaultLibraries)</IgnoreSpecificDefaultLibraries>
       <BaseAddress>0x1e000000</BaseAddress>
     </Link>
+    <PreBuildEvent>
+      <Command>$(KillPythonExe)</Command>
+    </PreBuildEvent>
+    <PreBuildEvent>
+      <Message>Killing any running $(PythonExe) instances...</Message>
+    </PreBuildEvent>
   </ItemDefinitionGroup>
   <ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='PGInstrument|Win32'">
     <ClCompile>
@@ -282,6 +306,12 @@
       <IgnoreSpecificDefaultLibraries>libc;%(IgnoreSpecificDefaultLibraries)</IgnoreSpecificDefaultLibraries>
       <BaseAddress>0x1e000000</BaseAddress>
     </Link>
+    <PreBuildEvent>
+      <Command>$(KillPythonExe)</Command>
+    </PreBuildEvent>
+    <PreBuildEvent>
+      <Message>Killing any running $(PythonExe) instances...</Message>
+    </PreBuildEvent>
   </ItemDefinitionGroup>
   <ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='PGInstrument|x64'">
     <Midl>
@@ -308,6 +338,12 @@
       <BaseAddress>0x1e000000</BaseAddress>
       <TargetMachine>MachineX64</TargetMachine>
     </Link>
+    <PreBuildEvent>
+      <Command>$(KillPythonExe)</Command>
+    </PreBuildEvent>
+    <PreBuildEvent>
+      <Message>Killing any running $(PythonExe) instances...</Message>
+    </PreBuildEvent>
   </ItemDefinitionGroup>
   <ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='PGUpdate|Win32'">
     <ClCompile>
@@ -331,6 +367,12 @@
       <IgnoreSpecificDefaultLibraries>libc;%(IgnoreSpecificDefaultLibraries)</IgnoreSpecificDefaultLibraries>
       <BaseAddress>0x1e000000</BaseAddress>
     </Link>
+    <PreBuildEvent>
+      <Command>$(KillPythonExe)</Command>
+    </PreBuildEvent>
+    <PreBuildEvent>
+      <Message>Killing any running $(PythonExe) instances...</Message>
+    </PreBuildEvent>
   </ItemDefinitionGroup>
   <ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='PGUpdate|x64'">
     <Midl>
@@ -357,6 +399,12 @@
       <BaseAddress>0x1e000000</BaseAddress>
       <TargetMachine>MachineX64</TargetMachine>
     </Link>
+    <PreBuildEvent>
+      <Command>$(KillPythonExe)</Command>
+    </PreBuildEvent>
+    <PreBuildEvent>
+      <Message>Killing any running $(PythonExe) instances...</Message>
+    </PreBuildEvent>
   </ItemDefinitionGroup>
   <ItemGroup>
     <ClInclude Include="..\Include\abstract.h" />

diff --git a/Tools/buildbot/build-amd64.bat b/Tools/buildbot/build-amd64.bat
index 7ee7b2d9b3632744d412fa18d07bd1cfdad9c88d..493e74de5a3e4fadf67b6099b555517952b351f4 100644 (file)
--- a/Tools/buildbot/build-amd64.bat
+++ b/Tools/buildbot/build-amd64.bat
@@ -2,6 +2,5 @@
 cmd /c Tools\buildbot\external-amd64.bat
 call "%VS100COMNTOOLS%\..\..\VC\vcvarsall.bat" x86_amd64
 cmd /c Tools\buildbot\clean-amd64.bat
-msbuild PCbuild\kill_python.vcxproj /p:Configuration=Debug /p:PlatformTarget=x64
-PCbuild\amd64\kill_python_d.exe
+
 msbuild PCbuild\pcbuild.sln /p:Configuration=Debug /p:Platform=x64

diff --git a/Tools/buildbot/build.bat b/Tools/buildbot/build.bat
index c93cfd554bda933b93b11f531f58ab27298ab802..be79b10726d70c0327e4defbc6eb293ea8daa0ba 100644 (file)
--- a/Tools/buildbot/build.bat
+++ b/Tools/buildbot/build.bat
@@ -2,7 +2,6 @@
 cmd /c Tools\buildbot\external.bat
 call "%VS100COMNTOOLS%vsvars32.bat"
 cmd /c Tools\buildbot\clean.bat
-msbuild PCbuild\kill_python.vcxproj /p:Configuration=Debug /p:PlatformTarget=x86
-PCbuild\kill_python_d.exe
+
 msbuild PCbuild\pcbuild.sln /p:Configuration=Debug /p:Platform=Win32