]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
RawDCERPCTest: add some more auth_length related asserts
authorStefan Metzmacher <metze@samba.org>
Wed, 11 Nov 2020 15:49:25 +0000 (16:49 +0100)
committerAndreas Schneider <asn@cryptomilk.org>
Thu, 10 Oct 2024 14:01:04 +0000 (14:01 +0000)
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14356

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
python/samba/tests/dcerpc/raw_testcase.py

index aaf063c217992620cffa4534724d1620f3c06328..e45f20ef929449ad40499277ce3249131153d7fb 100644 (file)
@@ -889,6 +889,7 @@ class RawDCERPCTest(TestCase):
         if len(ai) > samba.dcerpc.dcerpc.DCERPC_AUTH_TRAILER_LENGTH:
             p.auth_length = len(ai) - samba.dcerpc.dcerpc.DCERPC_AUTH_TRAILER_LENGTH
         else:
+            self.assertEqual(len(ai), 0)
             p.auth_length = 0
         p.call_id = call_id
         p.u = payload
@@ -1001,10 +1002,10 @@ class RawDCERPCTest(TestCase):
         if len(ai) > samba.dcerpc.dcerpc.DCERPC_AUTH_TRAILER_LENGTH:
             self.assertEqual(p.auth_length,
                              len(ai) - samba.dcerpc.dcerpc.DCERPC_AUTH_TRAILER_LENGTH)
-        elif auth_length is not None:
-            self.assertEqual(p.auth_length, auth_length)
-        else:
+        elif auth_length is None:
             self.assertEqual(p.auth_length, 0)
+        if auth_length is not None:
+            self.assertEqual(p.auth_length, auth_length)
         self.assertEqual(p.call_id, call_id)
 
         return