]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
s3:libads: Fix size types in kerberos functions
authorAndreas Schneider <asn@samba.org>
Thu, 7 Dec 2017 16:38:21 +0000 (17:38 +0100)
committerJeremy Allison <jra@samba.org>
Tue, 20 Mar 2018 22:16:14 +0000 (23:16 +0100)
This fixes compilation with -Wstrict-overflow=2

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
source3/libads/kerberos.c

index cfb09a704cbf84a3734812dca3032ac4921c7bad..82f118a021e48e6e3f75fc1d235065db2c5007ab 100644 (file)
@@ -336,10 +336,10 @@ int kerberos_kinit_password(const char *principal,
 
 ************************************************************************/
 
-static void add_sockaddr_unique(struct sockaddr_storage *addrs, int *num_addrs,
+static void add_sockaddr_unique(struct sockaddr_storage *addrs, size_t *num_addrs,
                                const struct sockaddr_storage *addr)
 {
-       int i;
+       size_t i;
 
        for (i=0; i<*num_addrs; i++) {
                if (sockaddr_equal((const struct sockaddr *)&addrs[i],
@@ -382,12 +382,12 @@ static char *get_kdc_ip_string(char *mem_ctx,
                const struct sockaddr_storage *pss)
 {
        TALLOC_CTX *frame = talloc_stackframe();
-       int i;
+       size_t i;
        struct ip_service *ip_srv_site = NULL;
        struct ip_service *ip_srv_nonsite = NULL;
        int count_site = 0;
        int count_nonsite;
-       int num_dcs;
+       size_t num_dcs;
        struct sockaddr_storage *dc_addrs;
        struct tsocket_address **dc_addrs2 = NULL;
        const struct tsocket_address * const *dc_addrs3 = NULL;
@@ -448,7 +448,7 @@ static char *get_kdc_ip_string(char *mem_ctx,
                                      struct tsocket_address *,
                                      num_dcs);
 
-       DEBUG(10, ("%d additional KDCs to test\n", num_dcs));
+       DBG_DEBUG("%zu additional KDCs to test\n", num_dcs);
        if (num_dcs == 0) {
                goto out;
        }