Bug 3173: Assertion bodyPipe!=NULL on SslBump CONNECT response writing failure

Do not call ConnStateData::startClosing() when we fail to write our CONNECT
response while bumping a connection. startClosing() can only be used when we
handle response bodies. Just close the connection, in hope that the connection
close handler kicks in and cleans up.

diff --git a/src/client_side_request.cc b/src/client_side_request.cc
index a0034d9c5696b880a0450dc9295bec8121f3c350..aee8a0cd7799f8f23537c3e0841fca4386ec7b88 100644 (file)
--- a/src/client_side_request.cc
+++ b/src/client_side_request.cc
@@ -1178,7 +1178,8 @@ ClientHttpRequest::sslBumpEstablish(comm_err_t errflag)
         return;
 
     if (errflag) {
-        getConn()->startClosing("CONNECT response failure in SslBump");
+        debugs(85, 3, HERE << "CONNECT response failure in SslBump: " << errflag);
+        comm_close(getConn()->fd);
         return;
     }