BZ#18921: Fix opendir inverted o_directory_works test.

diff --git a/ChangeLog b/ChangeLog
index 1db8e3197db5b309dbbe1db97795d38ba2b63a3a..53b6c2454951e96576ddb841b8470ac589dc34f1 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,11 @@
+2015-09-04  Roland McGrath  <roland@hack.frob.com>
+
+       [BZ #18921]
+       * sysdeps/posix/opendir.c (need_isdir_precheck) [O_DIRECTORY]:
+       Fix inverted sense of test of 'o_directory_works' value.
+       Reported by Pádraig Brady <P@draigBrady.com>, diagnosed by
+       Bernhard Voelker <mail@bernhard-voelker.de>.
+
 2015-09-04  Joseph Myers  <joseph@codesourcery.com>
 
        [BZ #14912]

diff --git a/sysdeps/posix/opendir.c b/sysdeps/posix/opendir.c
index 6509f5c05cd4319fa7f4148475eaa6fd8af61b20..9edf056fb30f433f90fa6e7971668247d3766cc7 100644 (file)
--- a/sysdeps/posix/opendir.c
+++ b/sysdeps/posix/opendir.c
@@ -105,7 +105,7 @@ need_isdir_precheck (void)
     tryopen_o_directory ();
 
   /* We can skip the expensive `stat' call if O_DIRECTORY works.  */
-  return o_directory_works > 0;
+  return o_directory_works < 0;
 #endif
   return true;
 }