]> git.ipfire.org Git - thirdparty/sqlalchemy/sqlalchemy.git/commitdiff
the order of rollback()s wasn't correct. slightly disturbing as the test usually...
authorMike Bayer <mike_mp@zzzcomputing.com>
Tue, 2 Feb 2010 23:26:34 +0000 (23:26 +0000)
committerMike Bayer <mike_mp@zzzcomputing.com>
Tue, 2 Feb 2010 23:26:34 +0000 (23:26 +0000)
began failing on PG as of somewhat unrelated commit r6705, and only when the full test/engine series
of tests were run.  very heisenbuggy. may want to add tests to assert that TLEngine is enforcing
nesting even with subtransactions.

test/engine/test_transaction.py

index 5be1d937401fe4cd164403a37c4571287d75ccca..de2cc46d33cf6c77c7fb5868e7496eadc87325dc 100644 (file)
@@ -829,6 +829,12 @@ class TLTransactionTest(TestBase):
         tlengine.begin()
         tlengine.execute(users.insert(), user_id=3, user_name='user3')
         tlengine.rollback()
+        
+        # TODO: removing this line, the test still tends to pass in most
+        # cases, except sporadically on PG.  this should be nailed down
+        # in TLEngine - removing this line should be guaranteed fail.
+        tlengine.rollback()
+        
         tlengine.execute(users.insert(), user_id=4, user_name='user4')
         tlengine.commit()
         tlengine.close()