]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
Fix error when running with -uall in test_unparse (GH-17739)
authorPablo Galindo <Pablogsal@gmail.com>
Sun, 29 Dec 2019 20:18:36 +0000 (20:18 +0000)
committerGitHub <noreply@github.com>
Sun, 29 Dec 2019 20:18:36 +0000 (20:18 +0000)
Lib/test/test_unparse.py

index 3e796860cbcf22ab23fbafca85608e2c3bb9e9e9..49767dbac16d11ffe42f31cc896e465ff950a70b 100644 (file)
@@ -303,17 +303,17 @@ class DirectoryTestCase(ASTTestCase):
             if not item.name.startswith("bad")
         ]
 
-        tests_to_run_always = {item for item in items if
-                               item.name in cls.run_always_files}
-
         # Test limited subset of files unless the 'cpu' resource is specified.
         if not test.support.is_resource_enabled("cpu"):
-            items = set(random.sample(items, 10))
 
-        # Make sure that at least tests that heavily use grammar features are
-        # considered to reduce the change of missing something.
+            tests_to_run_always = {item for item in items if
+                                   item.name in cls.run_always_files}
+
+            items = set(random.sample(items, 10))
 
-        items = list(items | tests_to_run_always)
+            # Make sure that at least tests that heavily use grammar features are
+            # always considered in order to reduce the chance of missing something.
+            items = list(items | tests_to_run_always)
 
         # bpo-31174: Store the names sample to always test the same files.
         # It prevents false alarms when hunting reference leaks.