]> git.ipfire.org Git - thirdparty/dovecot/core.git/commitdiff
login-proxy: client_proxy_failed() - minor code cleanup
authorTimo Sirainen <timo.sirainen@open-xchange.com>
Wed, 29 Apr 2020 12:15:27 +0000 (15:15 +0300)
committeraki.tuomi <aki.tuomi@open-xchange.com>
Mon, 25 May 2020 08:38:55 +0000 (08:38 +0000)
The comment wasn't true anymore.

src/login-common/client-common-auth.c

index a8bc41a43041c01e78875218ec5b0da58f0ea3be..eb70adbae1183a099aea952184c3d6cf38aa5f36 100644 (file)
@@ -306,9 +306,8 @@ void client_proxy_log_failure(struct client *client, const char *line)
 
 void client_proxy_failed(struct client *client, bool send_line)
 {
-       if (send_line) {
+       if (send_line)
                client_proxy_error(client, PROXY_FAILURE_MSG);
-       }
 
        if (client->proxy_sasl_client != NULL)
                dsasl_client_free(&client->proxy_sasl_client);
@@ -317,7 +316,6 @@ void client_proxy_failed(struct client *client, bool send_line)
        i_free_and_null(client->proxy_user);
        i_free_and_null(client->proxy_master_user);
 
-       /* call this last - it may destroy the client */
        client_auth_failed(client);
 }