]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
arm64: dts: qcom: sm7225-fairphone-fp4: Fix conflicting bias pinctrl
authorLuca Weiss <luca.weiss@fairphone.com>
Thu, 19 Mar 2026 08:55:00 +0000 (09:55 +0100)
committerBjorn Andersson <andersson@kernel.org>
Thu, 26 Mar 2026 14:40:49 +0000 (09:40 -0500)
The pinctrl nodes from sm6350.dtsi already contain a bias-* property, so
that needs to be deleted, otherwise the dtb will contain two conflicting
bias-* properties.

Reported-by: Conor Dooley <conor@kernel.org>
Closes: https://lore.kernel.org/r/20260310-maritime-silly-05e7b7e03aa6@spud/
Fixes: c4ef464b24c5 ("arm64: dts: qcom: sm7225-fairphone-fp4: Add Bluetooth")
Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Link: https://lore.kernel.org/r/20260319-fp4-uart1-fix-v1-1-f6b3fedef583@fairphone.com
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts

index a3c2b26736f471ee47c0a81c5b92758edb8a4aac..3964aae47fd4e99367ffb18f7bd9a757b7daefa0 100644 (file)
         * the Bluetooth module drives the pin in either
         * direction or leaves the pin fully unpowered.
         */
+       /delete-property/ bias-disable;
        bias-bus-hold;
 };
 
 &qup_uart1_rts {
        /* We'll drive RTS, so no pull */
        drive-strength = <2>;
+       /delete-property/ bias-pull-down;
        bias-disable;
 };
 
         * in tri-state (module powered off or not driving the
         * signal yet).
         */
+       /delete-property/ bias-disable;
        bias-pull-up;
 };
 
 &qup_uart1_tx {
        /* We'll drive TX, so no pull */
        drive-strength = <2>;
+       /delete-property/ bias-pull-up;
        bias-disable;
 };