]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
test: fix file descriptor leak in test-psi-util 22596/head
authorYu Watanabe <watanabe.yu+github@gmail.com>
Tue, 22 Feb 2022 12:46:41 +0000 (21:46 +0900)
committerYu Watanabe <watanabe.yu+github@gmail.com>
Tue, 22 Feb 2022 15:58:16 +0000 (00:58 +0900)
Fixes an issue reported in #22576.

src/test/test-psi-util.c

index ed465b807eb81d62c2ca3a707a89165be0b76660..111671c5a9fc73150d82b9ea154dbb00bb8ba60d 100644 (file)
@@ -1,20 +1,23 @@
 /* SPDX-License-Identifier: LGPL-2.1-or-later */
 
 #include "alloc-util.h"
+#include "fd-util.h"
 #include "fileio.h"
 #include "fs-util.h"
 #include "parse-util.h"
 #include "psi-util.h"
 #include "tests.h"
+#include "tmpfile-util.h"
 
 TEST(read_mem_pressure) {
         _cleanup_(unlink_tempfilep) char path[] = "/tmp/pressurereadtestXXXXXX";
+        _cleanup_close_ int fd = -1;
         ResourcePressure rp;
 
         if (geteuid() != 0)
                 return (void) log_tests_skipped("not root");
 
-        assert_se(mkstemp(path));
+        assert_se((fd = mkostemp_safe(path)) >= 0);
 
         assert_se(read_resource_pressure("/verylikelynonexistentpath", PRESSURE_TYPE_SOME, &rp) < 0);
         assert_se(read_resource_pressure(path, PRESSURE_TYPE_SOME, &rp) < 0);