Use correct type for catalog_xmin

Commit 85c17f6 mistakenly declared a variable storing catalog_xmin as
XLogRecPtr, even though catalog_xmin is a TransactionId.

This caused no functional issue, but the type was clearly incorrect.
Therefore, this commit fixes it to use the correct type TransactionId
instead, and backpatch to v17 where the issue was introduced.

Author: Imran Zaheer <imran.zhir@gmail.com>
Reviewed-by: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
Reviewed-by: Fujii Masao <masao.fujii@gmail.com>
Discussion: https://postgr.es/m/CA+UBfa=mNeLt-4BFjEP4tqdDsnq+oMqqPr7fd9Wji2_9YXmQdA@mail.gmail.com

diff --git a/src/backend/replication/logical/slotsync.c b/src/backend/replication/logical/slotsync.c
index 3cbcd77d12fe24754df8c0bcee18ec0e34f9c047..bc42d74fec24e8a782960f9d9f597f27991bc2c7 100644 (file)
--- a/src/backend/replication/logical/slotsync.c
+++ b/src/backend/replication/logical/slotsync.c
@@ -282,7 +282,7 @@ update_local_synced_slot(RemoteSlot *remote_slot, Oid remote_dbid,
                {
                        XLogRecPtr      old_confirmed_lsn = slot->data.confirmed_flush;
                        XLogRecPtr      old_restart_lsn = slot->data.restart_lsn;
-                       XLogRecPtr      old_catalog_xmin = slot->data.catalog_xmin;
+                       TransactionId old_catalog_xmin = slot->data.catalog_xmin;
 
                        LogicalSlotAdvanceAndCheckSnapState(remote_slot->confirmed_lsn,
                                                                                                found_consistent_snapshot);