]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/bridge: cadence: cdns-mhdp8546-core: Reduce log level for DPCD read/write
authorJayesh Choudhary <j-choudhary@ti.com>
Tue, 9 Dec 2025 12:03:32 +0000 (17:33 +0530)
committerLuca Ceresoli <luca.ceresoli@bootlin.com>
Mon, 9 Mar 2026 17:57:19 +0000 (18:57 +0100)
Reduce the log level for cdns_mhdp_dpcd_read and cdns_mhdp_dpcd_write
errors in cdns_mhdp_transfer function as in case of failure, there is
flooding of these prints along with other indicators like EDID failure
logs which are fairly intuitive in themselves rendering these error logs
useless.
Also, the caller functions for the cdns_mhdp_transfer in drm_dp_helper.c
(which calls it 32 times), has debug log level in case transfer fails.
So having a superseding log level in cdns_mhdp_transfer seems bad.

Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Signed-off-by: Jayesh Choudhary <j-choudhary@ti.com>
Signed-off-by: Harikrishna Shenoy <h-shenoy@ti.com>
Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
Link: https://patch.msgid.link/20251209120332.3559893-7-h-shenoy@ti.com
Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c

index 89cf8cb37cd3f66bc469be1fe438ed49f451a026..945bb47c172ba44c77c65adad495243f8df8e535 100644 (file)
@@ -778,7 +778,7 @@ static ssize_t cdns_mhdp_transfer(struct drm_dp_aux *aux,
                        if (!ret)
                                continue;
 
-                       dev_err(mhdp->dev,
+                       dev_dbg(mhdp->dev,
                                "Failed to write DPCD addr %u\n",
                                msg->address + i);
 
@@ -788,7 +788,7 @@ static ssize_t cdns_mhdp_transfer(struct drm_dp_aux *aux,
                ret = cdns_mhdp_dpcd_read(mhdp, msg->address,
                                          msg->buffer, msg->size);
                if (ret) {
-                       dev_err(mhdp->dev,
+                       dev_dbg(mhdp->dev,
                                "Failed to read DPCD addr %u\n",
                                msg->address);