Always treat failure to allocate an RSA key as an unrecoverable allocation error

diff --git a/changes/bug2378 b/changes/bug2378
new file mode 100644 (file)
index 0000000..a3ae196
--- /dev/null
+++ b/changes/bug2378
@@ -0,0 +1,3 @@
+  o Minor code simplifications and refactorings
+    - Always treat failure to allocate an RSA key as an unrecoverable
+      allocation error.

diff --git a/src/common/crypto.c b/src/common/crypto.c
index 4223b10a7f683e7e83f54e7cb8dc17dc00091d86..09d7fc886b15c0a4aca19f374dc04ad297bb3161 100644 (file)
--- a/src/common/crypto.c
+++ b/src/common/crypto.c
@@ -379,7 +379,7 @@ crypto_new_pk_env(void)
   RSA *rsa;
 
   rsa = RSA_new();
-  if (!rsa) return NULL;
+  tor_assert(rsa);
   return _crypto_new_pk_env_rsa(rsa);
 }