]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
bpo-36854: Fix reference counter in PyInit__testcapi() (GH-17338)
authorMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Fri, 22 Nov 2019 12:56:59 +0000 (04:56 -0800)
committerGitHub <noreply@github.com>
Fri, 22 Nov 2019 12:56:59 +0000 (04:56 -0800)
Increment properly Py_True/Py_False reference counter for
_testcapi.WITH_PYMALLOC variable.
(cherry picked from commit 84c36c152a2bdf98f9cc7ce0e1db98e1f442a05e)

Co-authored-by: Victor Stinner <vstinner@python.org>
Modules/_testcapimodule.c

index 64b7b690493948b91d4a9676ea05feca80086f64..16ea9c2d665545a4663b43e38f5d570d0c165c96 100644 (file)
@@ -5444,11 +5444,14 @@ PyInit__testcapi(void)
     PyModule_AddObject(m, "instancemethod", (PyObject *)&PyInstanceMethod_Type);
 
     PyModule_AddIntConstant(m, "the_number_three", 3);
+    PyObject *v;
 #ifdef WITH_PYMALLOC
-    PyModule_AddObject(m, "WITH_PYMALLOC", Py_True);
+    v = Py_True;
 #else
-    PyModule_AddObject(m, "WITH_PYMALLOC", Py_False);
+    v = Py_False;
 #endif
+    Py_INCREF(v);
+    PyModule_AddObject(m, "WITH_PYMALLOC", v);
 
     TestError = PyErr_NewException("_testcapi.error", NULL, NULL);
     Py_INCREF(TestError);