]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
network: add more error logs
authorYu Watanabe <watanabe.yu+github@gmail.com>
Sun, 17 Nov 2019 13:39:42 +0000 (22:39 +0900)
committerZbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Mon, 18 Nov 2019 14:26:55 +0000 (15:26 +0100)
src/network/networkd-dhcp-server.c

index 79ac325926233a60e7b0aa25dfebeef2d35a1673..279f7789cb928fa20704d2d8afd76c022dbb9d50 100644 (file)
@@ -200,14 +200,14 @@ int dhcp4_server_configure(Link *link) {
 
         address = link_find_dhcp_server_address(link);
         if (!address)
-                return log_link_warning_errno(link, SYNTHETIC_ERRNO(EBUSY),
-                                              "Failed to find suitable address for DHCPv4 server instance.");
+                return log_link_error_errno(link, SYNTHETIC_ERRNO(EBUSY),
+                                            "Failed to find suitable address for DHCPv4 server instance.");
 
         /* use the server address' subnet as the pool */
         r = sd_dhcp_server_configure_pool(link->dhcp_server, &address->in_addr.in, address->prefixlen,
                                           link->network->dhcp_server_pool_offset, link->network->dhcp_server_pool_size);
         if (r < 0)
-                return r;
+                return log_link_error_errno(link, r, "Failed to configure address pool for DHCPv4 server instance: %m");
 
         /* TODO:
         r = sd_dhcp_server_set_router(link->dhcp_server, &main_address->in_addr.in);
@@ -219,14 +219,14 @@ int dhcp4_server_configure(Link *link) {
                 r = sd_dhcp_server_set_max_lease_time(link->dhcp_server,
                                                       DIV_ROUND_UP(link->network->dhcp_server_max_lease_time_usec, USEC_PER_SEC));
                 if (r < 0)
-                        return r;
+                        return log_link_error_errno(link, r, "Failed to set maximum lease time for DHCPv4 server instance: %m");
         }
 
         if (link->network->dhcp_server_default_lease_time_usec > 0) {
                 r = sd_dhcp_server_set_default_lease_time(link->dhcp_server,
                                                           DIV_ROUND_UP(link->network->dhcp_server_default_lease_time_usec, USEC_PER_SEC));
                 if (r < 0)
-                        return r;
+                        return log_link_error_errno(link, r, "Failed to set default lease time for DHCPv4 server instance: %m");
         }
 
         if (link->network->dhcp_server_emit_dns) {
@@ -302,7 +302,7 @@ int dhcp4_server_configure(Link *link) {
 
                 r = sd_dhcp_server_set_timezone(link->dhcp_server, tz);
                 if (r < 0)
-                        return r;
+                        return log_link_error_errno(link, r, "Failed to set timezone for DHCP server: %m");
         }
 
         ORDERED_HASHMAP_FOREACH(p, link->network->dhcp_server_raw_options, i) {
@@ -310,7 +310,7 @@ int dhcp4_server_configure(Link *link) {
                 if (r == -EEXIST)
                         continue;
                 if (r < 0)
-                        return r;
+                        return log_link_error_errno(link, r, "Failed to set DHCPv4 option: %m");
         }
 
         if (!sd_dhcp_server_is_running(link->dhcp_server)) {