Fix an oversight in r83294. unquote() should reject bytes. Issue #9301.

diff --git a/Lib/test/test_urllib.py b/Lib/test/test_urllib.py
index c68fe54b939822ae4eae23a91616e355cd5a5068..cea153e907a6330afa0e7d30d326605ceb95979e 100644 (file)
--- a/Lib/test/test_urllib.py
+++ b/Lib/test/test_urllib.py
@@ -557,6 +557,7 @@ class UnquotingTests(unittest.TestCase):
                          "%s" % result)
         self.assertRaises((TypeError, AttributeError), urllib.parse.unquote, None)
         self.assertRaises((TypeError, AttributeError), urllib.parse.unquote, ())
+        self.assertRaises((TypeError, AttributeError), urllib.parse.unquote, b'')
 
     def test_unquoting_badpercent(self):
         # Test unquoting on bad percent-escapes

diff --git a/Lib/urllib/parse.py b/Lib/urllib/parse.py
index a9fa26ad8f6b4f065ab4c16e94222a900357397e..133b9d99b60dd54964dd8dc47fc4cfef8586ba0e 100644 (file)
--- a/Lib/urllib/parse.py
+++ b/Lib/urllib/parse.py
@@ -338,7 +338,7 @@ def unquote(string, encoding='utf-8', errors='replace'):
 
     unquote('abc%20def') -> 'abc def'.
     """
-    if string in (b'', ''):
+    if string == '':
         return string
     res = string.split('%')
     if len(res) == 1: