util: fix potential OOB write in the symlinks build helper

Addresses-Coverity-Bug: 1432089
Addresses-Coverity-Bug: 1433050
Signed-off-by: Theodore Ts'o <tytso@mit.edu>

diff --git a/util/symlinks.c b/util/symlinks.c
index 4b0b788e0f4f30b19f4adb3dfdfa61360a2f8db0..cb74fc78515041a2795ad96222b960eb2d73bb51 100644 (file)
--- a/util/symlinks.c
+++ b/util/symlinks.c
@@ -56,7 +56,7 @@ static int substr (char *s, char *old, char *new)
                newlen = strlen(new);
 
        if (newlen > oldlen) {
-               if ((tmp = malloc(strlen(s))) == NULL) {
+               if ((tmp = malloc(strlen(s)+1)) == NULL) {
                        fprintf(stderr, "no memory\n");
                        exit (1);
                }