Remove redundant NULL checks in OpenSSL RSA glue

The OpenSSL free functions are no-op when called with NULL argument,
thus remove the extra checks around *_free() calls in the OpenSSL RSA
glue.

diff --git a/lib/dns/opensslrsa_link.c b/lib/dns/opensslrsa_link.c
index f5017b65f7fbe229b1338773901a609aac9614f2..cb815b73cc3b93b58fb739255164aa84b5f3efe5 100644 (file)
--- a/lib/dns/opensslrsa_link.c
+++ b/lib/dns/opensslrsa_link.c
@@ -378,15 +378,9 @@ opensslrsa_generate_pkey(unsigned int key_size, BIGNUM *e,
        ret = ISC_R_SUCCESS;
 
 err:
-       if (pkey != NULL) {
-               EVP_PKEY_free(pkey);
-       }
-       if (rsa != NULL) {
-               RSA_free(rsa);
-       }
-       if (cb != NULL) {
-               BN_GENCB_free(cb);
-       }
+       EVP_PKEY_free(pkey);
+       RSA_free(rsa);
+       BN_GENCB_free(cb);
        return (ret);
 }
 
@@ -511,9 +505,7 @@ opensslrsa_generate_pkey(unsigned int key_size, BIGNUM *e,
        }
        ret = ISC_R_SUCCESS;
 err:
-       if (ctx != NULL) {
-               EVP_PKEY_CTX_free(ctx);
-       }
+       EVP_PKEY_CTX_free(ctx);
        return (ret);
 }
 
@@ -668,12 +660,8 @@ opensslrsa_generate(dst_key_t *key, int exp, void (*callback)(int)) {
        ret = ISC_R_SUCCESS;
 
 err:
-       if (pkey != NULL) {
-               EVP_PKEY_free(pkey);
-       }
-       if (e != NULL) {
-               BN_free(e);
-       }
+       EVP_PKEY_free(pkey);
+       BN_free(e);
        return (ret);
 }