]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
drm/panic: Do not select DRM_KMS_HELPER
authorGeert Uytterhoeven <geert+renesas@glider.be>
Wed, 26 Jun 2024 08:41:44 +0000 (10:41 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 3 Aug 2024 07:00:02 +0000 (09:00 +0200)
[ Upstream commit e044e707fc97dac693691178cdf41fe1a8da928f ]

DRM core code cannot call into DRM helper code, as this would lead to
circular references in the modular case.  Hence drop the selection of
DRM_KMS_HELPER.  It was unused anyway, as v10 switched from using
the DRM format helpers to its own color format conversion, cfr. commit
9544309775c3 ("drm/panic: Add support for color format conversion").

Remove the unneeded include of <drm/drm_format_helper.h>.

Fixes: bf9fb17c6672 ("drm/panic: Add a drm panic handler")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Jocelyn Falempe <jfalempe@redhat.com>
Signed-off-by: Jocelyn Falempe <jfalempe@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/60155f8c939ed286e324a7c12a1daa69fe49fcf6.1719391132.git.geert+renesas@glider.be
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/gpu/drm/Kconfig
drivers/gpu/drm/drm_panic.c

index 3e286236aa430788bcd026a3b34da8fa2192b69a..359b68adafc1bb11457d55d1d26ef491bc6816b8 100644 (file)
@@ -107,7 +107,6 @@ config DRM_KMS_HELPER
 config DRM_PANIC
        bool "Display a user-friendly message when a kernel panic occurs"
        depends on DRM && !(FRAMEBUFFER_CONSOLE && VT_CONSOLE)
-       select DRM_KMS_HELPER
        select FONT_SUPPORT
        help
          Enable a drm panic handler, which will display a user-friendly message
index e1c47966856921bef875aafb3850dd2a990800ba..831b214975a515fb27a1327b22bb674b0640f4ec 100644 (file)
@@ -15,7 +15,6 @@
 #include <linux/types.h>
 
 #include <drm/drm_drv.h>
-#include <drm/drm_format_helper.h>
 #include <drm/drm_fourcc.h>
 #include <drm/drm_framebuffer.h>
 #include <drm/drm_modeset_helper_vtables.h>