but only close it if we have marked an earlier helper as up.

that way we don't close it too needlessly.

svn:r5671

diff --git a/src/or/circuitbuild.c b/src/or/circuitbuild.c
index da87ca48c895eaa7de1d08545e295cdcdb6d7eb9..154f687f59e1f328409fa86c2718a2c9978ae209 100644 (file)
--- a/src/or/circuitbuild.c
+++ b/src/or/circuitbuild.c
@@ -1957,12 +1957,12 @@ helper_node_set_status(const char *digest, int succeeded)
              * helpers another try too, and close this connection so
              * we don't use it before we've given the others a shot. */
             helper->made_contact = 1;
-            refuse_conn = 1;
             SMARTLIST_FOREACH(helper_nodes, helper_node_t *, h,
               {
                 routerinfo_t *r = router_get_by_digest(h->identity);
                 if (h->made_contact) {
                   h->down_since = 0;
+                  refuse_conn = 1;
                   if (r) r->is_running = 1;
                 }
                 if (h == helper)