]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
kaiser: Set _PAGE_NX only if supported
authorLepton Wu <ytht.net@gmail.com>
Fri, 12 Jan 2018 21:42:56 +0000 (13:42 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 17 Jan 2018 08:35:30 +0000 (09:35 +0100)
This finally resolve crash if loaded under qemu + haxm. Haitao Shan pointed
out that the reason of that crash is that NX bit get set for page tables.
It seems we missed checking if _PAGE_NX is supported in kaiser_add_user_map

Link: https://www.spinics.net/lists/kernel/msg2689835.html
Reviewed-by: Guenter Roeck <groeck@chromium.org>
Signed-off-by: Lepton Wu <ytht.net@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
arch/x86/mm/kaiser.c

index 6a7a77929a8cd230433b3b75b5050b8831680f46..8af98513d36cae45dd48546a097eceaadbd1f2a3 100644 (file)
@@ -198,6 +198,8 @@ static int kaiser_add_user_map(const void *__start_addr, unsigned long size,
         * requires that not to be #defined to 0): so mask it off here.
         */
        flags &= ~_PAGE_GLOBAL;
+       if (!(__supported_pte_mask & _PAGE_NX))
+               flags &= ~_PAGE_NX;
 
        for (; address < end_addr; address += PAGE_SIZE) {
                target_address = get_pa_from_mapping(address);