Fix a bogus warning

diff --git a/changes/dont-warn-about-rfc1918-socksport-addrs b/changes/dont-warn-about-rfc1918-socksport-addrs
new file mode 100644 (file)
index 0000000..9482599
--- /dev/null
+++ b/changes/dont-warn-about-rfc1918-socksport-addrs
@@ -0,0 +1,7 @@
+  o Minor bugfixes:
+
+    - Don't warn users that they are exposing a client port to the
+      Internet if they have specified an RFC1918 address.  Previously,
+      we would warn if the user had specified any non-loopback
+      address.  Bugfix on 0.2.3.3-alpha.  Fixes bug 4018; reported by Tas.
+

diff --git a/src/or/config.c b/src/or/config.c
index bc77b3a77e10406afa9f2f56a57fe17f4e3af42b..51cab8143124d03cf1a527e55ac20c14651496c2 100644 (file)
--- a/src/or/config.c
+++ b/src/or/config.c
@@ -4912,12 +4912,13 @@ port_cfg_free(port_cfg_t *port)
   tor_free(port);
 }
 
-/** Warn for every port in <b>ports</b> that is not on a loopback address. */
+/** Warn for every port in <b>ports</b> that is on a publicly routable
+ * address. */
 static void
 warn_nonlocal_client_ports(const smartlist_t *ports, const char *portname)
 {
   SMARTLIST_FOREACH_BEGIN(ports, const port_cfg_t *, port) {
-    if (!tor_addr_is_loopback(&port->addr)) {
+    if (!tor_addr_is_internal(&port->addr, 1)) {
       log_warn(LD_CONFIG, "You specified a public address for %sPort. "
                "Other people on the Internet might find your computer and "
                "use it as an open proxy. Please don't allow this unless you "